fix: don't panic when calling NewCtrlFuncMetrics() more than once #3473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It seems that we never tested calling
dataplane.NewKongClient()
, specifically more than once.This PR fixes a panic which occurs when calling
NewKongClient()
twice. This is due to the fact that we call.MustRegister()
onkubernetes-ingress-controller/internal/metrics/prometheus.go
Line 111 in 0f55f29
RegistererGatherer
.Special notes for your reviewer:
Found when adding tests for #3421