Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable ReferenceGrant controller if Gateway feature gate turned on #3519

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Feb 9, 2023

What this PR does / why we need it:

Since ReferenceGrant has been promoted to beta, we should enable it by default if gateway turned on.

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner February 9, 2023 07:03
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 74.0% // Head: 73.8% // Decreases project coverage by -0.2% ⚠️

Coverage data is based on head (4bee205) compared to base (d839f48).
Patch coverage: 100.0% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3519     +/-   ##
=======================================
- Coverage   74.0%   73.8%   -0.2%     
=======================================
  Files        116     116             
  Lines      13883   13883             
=======================================
- Hits       10277   10258     -19     
- Misses      2949    2962     +13     
- Partials     657     663      +6     
Impacted Files Coverage Δ
internal/manager/controllerdef.go 98.7% <100.0%> (ø)
...nternal/controllers/gateway/udproute_controller.go 71.6% <0.0%> (-2.2%) ⬇️
...nternal/controllers/gateway/tlsroute_controller.go 71.4% <0.0%> (-2.1%) ⬇️
...ternal/controllers/gateway/httproute_controller.go 69.7% <0.0%> (-1.9%) ⬇️
internal/dataplane/parser/parser.go 90.7% <0.0%> (+0.6%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but other than that 👍

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Patryk Małek <[email protected]>
@randmonkey randmonkey merged commit ba09da5 into main Feb 9, 2023
@randmonkey randmonkey deleted the feat/reference_grant_default_on branch February 9, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants