Feat/credentials sync #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credential sync for DB mode has now been moved to decK: - multiple credentials of the same type can be provisioned - any change to credentials will now be propagated to Kong #230 With this change, all syncing is now done via decK, providing for a stable sync with least API calls. There exists one caveat here, any change to password for basic-auth will not result in a change in Kong because it is not possible to diff passwords as Kong hashes them in the API response and DB. There will be a follow up commit to work around this limitation. For DB-less mode, the parsing becomes simpler but no functional change should happen. This change also lays the foundation for secret based credentials in future.
With passwords hashed in Kong, decK can not detect a drift when the password is changed. This change syncs the password change to Kong. Username changes result in re-creation of the credential in Kong and they are taken care of by decK. This change has no effect on the DB-less deployments.
hbagdi
force-pushed
the
feat/credentials-sync
branch
from
0011b3a
to
a4ce877
Compare
This was referenced Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.