-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix flaky gateway conformance HTTPRouteListenerHostnameMatching
test
#3732
tests: fix flaky gateway conformance HTTPRouteListenerHostnameMatching
test
#3732
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3732 +/- ##
=====================================
Coverage 73.5% 73.5%
=====================================
Files 133 133
Lines 15843 15828 -15
=====================================
- Hits 11651 11646 -5
+ Misses 3431 3423 -8
+ Partials 761 759 -2
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
d035e24
to
1688039
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this has already been merged and I'm late, but I wonder how this missing field can produce failures in an inconsistent way in our conformance tests 🤔
Missing section name was one of the things fixed in this PR. The problem apart from this one was most likely due to inconsistent status processing and at times, creating 2 nearly equal parent statuses for a route, which caused the "expect 1 parent, got 2" error in test logs. |
Gotcha, thanks for the explanation 🙏 |
What this PR does / why we need it:
This fixes setting the incorrect status for Gateway API routes.
ParentReference
when it was specifiedParentRefs
The relevant conformance test was run multiple times in a loop locally to ensure the fix is in place.
Which issue this PR fixes:
Fixes: #3721
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR