-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --gateway-discovery-dns-strategy
flag
#4071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
commented
May 24, 2023
pmalek
force-pushed
the
gateway-discovery-dns-strategy
branch
from
May 25, 2023 13:00
ceabe75
to
13a4376
Compare
pmalek
changed the title
wip: add --gateway-discovery-dns-strategy flag
feat: add May 25, 2023
--gateway-discovery-dns-strategy
flag
pmalek
force-pushed
the
gateway-discovery-dns-strategy
branch
from
May 25, 2023 13:06
13a4376
to
f228c6b
Compare
pmalek
added
area/feature
New feature or request
and removed
work in progress
Work In Progress
labels
May 25, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4071 +/- ##
=======================================
+ Coverage 0 60.1% +60.1%
=======================================
Files 0 151 +151
Lines 0 16608 +16608
=======================================
+ Hits 0 9990 +9990
- Misses 0 5987 +5987
- Partials 0 631 +631
☔ View full report in Codecov by Sentry. |
pmalek
force-pushed
the
gateway-discovery-dns-strategy
branch
from
May 25, 2023 13:24
f228c6b
to
dd20d7b
Compare
czeslavo
approved these changes
May 25, 2023
1 task
czeslavo
previously approved these changes
May 25, 2023
pmalek
force-pushed
the
gateway-discovery-dns-strategy
branch
from
May 25, 2023 17:03
1a1a940
to
6d58c30
Compare
randmonkey
reviewed
May 26, 2023
randmonkey
approved these changes
May 26, 2023
This was referenced May 26, 2023
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces
--gateway-discovery-dns-strategy
flag which allow users to specify which strategy to use when creating address of Admin API endpoints.There are 3 options that are accepted as values for this flag:
service
- for service scoped pod dns names:pod-ip-address.service-name.my-namespace.svc.cluster-domain.example
pod
- for namespace scope pod dns names:pod-ip-address.my-namespace.pod.cluster-domain.example
ip
(default, retains v2.9 behavior) - for regular IP addressesWhich issue this PR fixes:
closes: #4065
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR