Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --gateway-discovery-dns-strategy flag #4071

Merged
merged 2 commits into from
May 26, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented May 24, 2023

What this PR does / why we need it:

This PR introduces --gateway-discovery-dns-strategy flag which allow users to specify which strategy to use when creating address of Admin API endpoints.

There are 3 options that are accepted as values for this flag:

  • service - for service scoped pod dns names: pod-ip-address.service-name.my-namespace.svc.cluster-domain.example
  • pod - for namespace scope pod dns names: pod-ip-address.my-namespace.pod.cluster-domain.example
  • ip (default, retains v2.9 behavior) - for regular IP addresses

Which issue this PR fixes:

closes: #4065

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek added the work in progress Work In Progress label May 24, 2023
@pmalek pmalek added this to the KIC v2.10.0 milestone May 24, 2023
@pmalek pmalek self-assigned this May 24, 2023
@pmalek pmalek force-pushed the gateway-discovery-dns-strategy branch from ceabe75 to 13a4376 Compare May 25, 2023 13:00
@pmalek pmalek changed the title wip: add --gateway-discovery-dns-strategy flag feat: add --gateway-discovery-dns-strategy flag May 25, 2023
@pmalek pmalek force-pushed the gateway-discovery-dns-strategy branch from 13a4376 to f228c6b Compare May 25, 2023 13:06
@pmalek pmalek added area/feature New feature or request and removed work in progress Work In Progress labels May 25, 2023
@pmalek pmalek marked this pull request as ready for review May 25, 2023 13:07
@pmalek pmalek requested a review from a team as a code owner May 25, 2023 13:07
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 78.3% and project coverage change: +60.1 🎉

Comparison is base (74b39d2) 0.0% compared to head (6d58c30) 60.1%.

Additional details and impacted files
@@           Coverage Diff           @@
##           main   #4071      +/-   ##
=======================================
+ Coverage      0   60.1%   +60.1%     
=======================================
  Files         0     151     +151     
  Lines         0   16608   +16608     
=======================================
+ Hits          0    9990    +9990     
- Misses        0    5987    +5987     
- Partials      0     631     +631     
Impacted Files Coverage Δ
internal/manager/config_validation.go 83.5% <0.0%> (ø)
internal/manager/setup.go 40.5% <0.0%> (ø)
...ntrollers/configuration/kongadminapi_controller.go 62.3% <23.0%> (ø)
internal/manager/config/types/dnsstrategy.go 83.3% <83.3%> (ø)
internal/adminapi/endpoints.go 88.1% <91.6%> (ø)
internal/manager/config.go 94.6% <100.0%> (ø)
internal/manager/controllerdef.go 98.8% <100.0%> (ø)
internal/util/builder/endpointport.go 100.0% <100.0%> (ø)

... and 143 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmalek pmalek force-pushed the gateway-discovery-dns-strategy branch from f228c6b to dd20d7b Compare May 25, 2023 13:24
@pmalek pmalek requested a review from czeslavo May 25, 2023 13:25
czeslavo
czeslavo previously approved these changes May 25, 2023
@pmalek pmalek force-pushed the gateway-discovery-dns-strategy branch from 1a1a940 to 6d58c30 Compare May 25, 2023 17:03
@pmalek pmalek requested a review from czeslavo May 25, 2023 18:11
@pmalek pmalek enabled auto-merge (squash) May 25, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GKE: Using pod dns names doesn't work on GKE which breaks Gateway Discovery
3 participants