Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser) error for all inconsistent services #4171

Merged
merged 3 commits into from
Jun 15, 2023
Merged

feat(parser) error for all inconsistent services #4171

merged 3 commits into from
Jun 15, 2023

Commits on Jun 14, 2023

  1. feat(parser) error for all inconsistent services 

    Emit errors for every Service in a multi-Service backend when an
annotation is inconsistent.

Previously, the parser would arbitrarily choose one annotation value as
the correct value and only log errors for Services with a different
value. There was no basis for choosing this as the correct value, it was
just the first observed value, and there was no indication which Service
was the source of the value. Logging for each informs users of the
complete set of Services.
    @rainest
    rainest committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    131ece4 View commit details
    Browse the repository at this point in the history

  2. chore(tests) remove error count check 

    Remove the error count check from TestPopulateServices. This test checks
whether a virtual service is skipped entirely, not the reason why. While
the only existing test case does generate an error per component
Service, this may not be the case for future skip reasons.

The error count for that case (annotation mismatch) is already tested
independently in the TestDoK8sServicesMatchAnnotations test specific to
that skip reason.
    @rainest
    rainest committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    696729b View commit details
    Browse the repository at this point in the history

  3. pr: address review comments 

    Use the apimachinery Set type instead of writing the map directly.

Add comments and rename functions to clarify when we filter out
interesting annotations.

Remove old TODO.
    @rainest
    rainest committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    32e7749 View commit details
    Browse the repository at this point in the history