Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support UDPRoute when expression router enabled #4550

Merged
merged 5 commits into from
Aug 25, 2023

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Aug 22, 2023

What this PR does / why we need it:

support UDPRoute with expression router when Kong version is >3.4, and add tests for it.

Which issue this PR fixes:

fixes #4539

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner August 22, 2023 09:54
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 75.0% and no project coverage change.

Comparison is base (6006cab) 68.4% compared to head (e1d0f2c) 68.5%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4550   +/-   ##
=====================================
  Coverage   68.4%   68.5%           
=====================================
  Files        162     162           
  Lines      19017   19030   +13     
=====================================
+ Hits       13023   13042   +19     
+ Misses      5227    5216   -11     
- Partials     767     772    +5     
Files Changed Coverage Δ
internal/dataplane/parser/translate_tcproute.go 57.1% <40.0%> (-1.5%) ⬇️
internal/dataplane/parser/translate_udproute.go 74.2% <84.2%> (+57.0%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randmonkey randmonkey added the area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API label Aug 22, 2023
@randmonkey randmonkey self-assigned this Aug 22, 2023
@randmonkey randmonkey added this to the KIC v2.12.0 milestone Aug 22, 2023
@randmonkey randmonkey marked this pull request as draft August 22, 2023 11:49
@randmonkey randmonkey force-pushed the feat/udproute_expression_router branch from c8be801 to 33ee856 Compare August 23, 2023 06:10
@randmonkey randmonkey marked this pull request as ready for review August 23, 2023 06:43
internal/dataplane/parser/translate_udproute.go Outdated Show resolved Hide resolved
internal/dataplane/parser/translate_udproute.go Outdated Show resolved Hide resolved
test/integration/version_test.go Outdated Show resolved Hide resolved
internal/dataplane/parser/translate_failures_test.go Outdated Show resolved Hide resolved
internal/dataplane/parser/translate_tcproute.go Outdated Show resolved Hide resolved
@randmonkey randmonkey merged commit 5984c8c into main Aug 25, 2023
33 checks passed
@randmonkey randmonkey deleted the feat/udproute_expression_router branch August 25, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support UDPRoute with expression router
2 participants