fix: add type meta when saving them to cache and reference indexer #4663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The PR sets type meta for objects when adding them to cache stores and reference indexers, and fetching objects referred by when the object gets deleted. This PR is added because cache indexers to store reference relations needs object kind(GVK) for indexing, and this comes from
TypeMeta
of the k8s resource.If we do not set the
TypeMeta
, the object kind of objects are always empty so we could not find them correctly in reference indexers.It also adds logs when setting or deleting reference relations between objects.
Which issue this PR fixes:
fixes #3201
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR