-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove everything related obsolete global KongPlugins #4737
Conversation
c495d03
to
59e302b
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4737 +/- ##
=======================================
- Coverage 67.9% 67.8% -0.1%
=======================================
Files 165 165
Lines 19291 19208 -83
=======================================
- Hits 13102 13029 -73
+ Misses 5420 5416 -4
+ Partials 769 763 -6
☔ View full report in Codecov by Sentry. |
59e302b
to
90347c6
Compare
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6338093891 |
What this PR does / why we need it:
KongClusterPlugin
supports the labelglobal: true
, see the docs and it is not changed.For a long time (since
KIC v0.10.0
) forKongPlugin
with the labelglobal: true
KIC logs a warning about unsupporting. This PR gets rid of everything related to the support of labelglobal
forKongPlugin
, including a warning.Which issue this PR fixes:
Closes #3873
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR