-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HTTPRoute extensionRef filter converted onto plugin #4838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlavacca
force-pushed
the
mlavacca/httproute-plugins
branch
from
October 13, 2023 16:28
b37b664
to
a9a2e4a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4838 +/- ##
=======================================
- Coverage 77.7% 77.5% -0.2%
=======================================
Files 165 166 +1
Lines 18480 18633 +153
=======================================
+ Hits 14359 14458 +99
- Misses 3296 3335 +39
- Partials 825 840 +15
☔ View full report in Codecov by Sentry. |
mlavacca
force-pushed
the
mlavacca/httproute-plugins
branch
from
October 23, 2023 10:57
a9a2e4a
to
33d502b
Compare
Signed-off-by: Mattia Lavacca <[email protected]>
mlavacca
force-pushed
the
mlavacca/httproute-plugins
branch
from
October 23, 2023 11:05
33d502b
to
5f4ec24
Compare
pmalek
reviewed
Oct 23, 2023
pmalek
reviewed
Oct 23, 2023
mlavacca
force-pushed
the
mlavacca/httproute-plugins
branch
from
October 23, 2023 15:55
a54d0dd
to
2e98900
Compare
pmalek
reviewed
Oct 23, 2023
mlavacca
force-pushed
the
mlavacca/httproute-plugins
branch
from
October 24, 2023 13:16
2e98900
to
c4a6bec
Compare
Signed-off-by: Mattia Lavacca <[email protected]>
mlavacca
force-pushed
the
mlavacca/httproute-plugins
branch
from
October 24, 2023 13:17
c4a6bec
to
5851d22
Compare
Co-authored-by: Jakub Warczarek <[email protected]>
mlavacca
force-pushed
the
mlavacca/httproute-plugins
branch
from
October 24, 2023 14:00
332d9f5
to
ddb9a65
Compare
programmer04
previously approved these changes
Oct 24, 2023
pmalek
reviewed
Oct 24, 2023
pmalek
previously approved these changes
Oct 24, 2023
pmalek
added
the
area/gateway-api
Relating to upstream Kubernetes SIG Networking Gateway API
label
Oct 24, 2023
Co-authored-by: Patryk Małek <[email protected]>
mlavacca
force-pushed
the
mlavacca/httproute-plugins
branch
from
October 24, 2023 16:52
fcfbb3e
to
b19b294
Compare
pmalek
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes:
Fixes #4812
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR