Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update gatewayv1beta1 to gatewayv1 in examples and docs #4935

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Oct 23, 2023

What this PR does / why we need it:

update Gateways, GatewayClasses and HTTPRoutes in manifests of examples to gateway.networking.k8s.io/v1 and also their appearance in docs.

Which issue this PR fixes:

fixes #4891

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner October 23, 2023 03:42
@randmonkey randmonkey added area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API ci/run-nightly Run nightly Kong image integration tests labels Oct 23, 2023
@randmonkey randmonkey added this to the KIC v3.0.0 milestone Oct 23, 2023
@team-k8s-bot
Copy link
Collaborator

Integration (targeted) tests with KIND-based cluster and latest images were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6608465283

@team-k8s-bot team-k8s-bot removed the ci/run-nightly Run nightly Kong image integration tests label Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8bbfd9) 77.7% compared to head (57ade56) 77.7%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4935     +/-   ##
=======================================
- Coverage   77.7%   77.7%   -0.1%     
=======================================
  Files        165     165             
  Lines      18477   18477             
=======================================
- Hits       14373   14367      -6     
- Misses      3281    3288      +7     
+ Partials     823     822      -1     
Files Coverage Δ
...ternal/controllers/gateway/httproute_controller.go 76.7% <ø> (-1.1%) ⬇️
...rnal/dataplane/parser/translators/httproute_atc.go 92.9% <ø> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randmonkey randmonkey added the ci/run-e2e Trigger e2e test run from PR label Oct 23, 2023
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6609261366

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Oct 23, 2023
@randmonkey randmonkey merged commit 628fe6a into main Oct 23, 2023
200 checks passed
@randmonkey randmonkey deleted the chore/update_examples_to_gatewayv1 branch October 23, 2023 09:59
rainest pushed a commit that referenced this pull request Oct 24, 2023
* update gatewayv1beta1 to gatewayv1 in examples and docs

* update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Gateway, GatewayClass and HTTPRoute in gateway API v1
3 participants