chore: remove (deprecate) all manifests from deploy/single #4970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmer04
force-pushed
the
deprecate-manifests
branch
from
58cd6e8
to
99ce61f
Compare
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6641141569 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4970 +/- ##
=======================================
- Coverage 77.7% 77.7% -0.1%
=======================================
Files 166 166
Lines 18642 18642
=======================================
- Hits 14493 14486 -7
- Misses 3315 3319 +4
- Partials 834 837 +3 ☔ View full report in Codecov by Sentry. |
czeslavo
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
From KIC 3.0.0 only Helm chart and Gateway Operator are official and supported ways to install KIC. This is breaking changes, but it leaves files to indicate that they have been deprecated. In the future, they will be removed too.
Which issue this PR fixes:
Closes #4712
Special notes for your reviewer:
Manifests are still used in e2e tests, so they are moved. Here is the dedicated issue
to get rid of them entirely.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR