Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logs): modifying the capitalization consistency of the logs - Part 2 #5035

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

pangruoran
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes:
part of #3708

more about admission.

Special notes for your reviewer:

It has been split from PR #4992 to make it easier to review.
PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pangruoran pangruoran changed the title chore(logs): modifying the capitalization consistency of the logs chore(logs): modifying the capitalization consistency of the logs - Part 2 Oct 31, 2023
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (dce791d) 75.5% compared to head (ada3b6e) 75.5%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5035   +/-   ##
=====================================
  Coverage   75.5%   75.5%           
=====================================
  Files        167     167           
  Lines      18848   18881   +33     
=====================================
+ Hits       14238   14274   +36     
+ Misses      3783    3782    -1     
+ Partials     827     825    -2     
Files Coverage Δ
internal/admission/validation/gateway/httproute.go 90.0% <80.0%> (ø)
internal/admission/validation/ingress/ingress.go 90.0% <0.0%> (ø)
internal/admission/validator.go 73.4% <50.0%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pangruoran pangruoran marked this pull request as ready for review November 1, 2023 07:51
@pangruoran pangruoran requested a review from a team as a code owner November 1, 2023 07:51
@pangruoran pangruoran merged commit bb20cb8 into main Nov 1, 2023
36 checks passed
@pangruoran pangruoran deleted the unified-log-case-part2 branch November 1, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants