Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logs): modifying the capitalization consistency of the logs - Part 3 #5037

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

pangruoran
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes:
part of #3708

Special notes for your reviewer:

It has been split from PR #4992 to make it easier to review.

This PR include two part:

  • sed -i 's/failed to/Failed to/g'
  • sed -i 's/could not/Could not/g'

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (dce791d) 75.5% compared to head (a20b269) 75.6%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5037   +/-   ##
=====================================
  Coverage   75.5%   75.6%           
=====================================
  Files        167     167           
  Lines      18848   18881   +33     
=====================================
+ Hits       14238   14278   +40     
+ Misses      3783    3779    -4     
+ Partials     827     824    -3     
Files Coverage Δ
...nal/controllers/configuration/secret_controller.go 56.0% <100.0%> (ø)
internal/dataplane/failures/failures.go 100.0% <100.0%> (ø)
internal/dataplane/kong_client.go 89.5% <100.0%> (-0.1%) ⬇️
internal/dataplane/parser/ingressrules.go 95.1% <100.0%> (ø)
internal/license/agent.go 90.8% <100.0%> (ø)
internal/admission/handler.go 61.0% <80.0%> (+1.5%) ⬆️
internal/admission/server.go 42.0% <0.0%> (ø)
internal/clients/readiness.go 89.1% <0.0%> (ø)
internal/controllers/reference/reference.go 50.5% <0.0%> (ø)
internal/dataplane/parser/parser.go 92.0% <66.6%> (+0.7%) ⬆️
... and 20 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pangruoran pangruoran marked this pull request as ready for review November 1, 2023 21:16
@pangruoran pangruoran requested a review from a team as a code owner November 1, 2023 21:16
@randmonkey randmonkey merged commit f69e15a into main Nov 2, 2023
36 checks passed
@randmonkey randmonkey deleted the unified-log-case-part3 branch November 2, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants