fix: change events emit toggle name to --emit-kubernetes-events #5299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
fix/emit-events-flag
branch
from
ce694f4
to
f367317
Compare
czeslavo
force-pushed
the
fix/emit-events-flag
branch
from
f367317
to
f06be10
Compare
2 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5299 +/- ##
=======================================
+ Coverage 75.7% 75.9% +0.1%
=======================================
Files 170 170
Lines 19457 19458 +1
=======================================
+ Hits 14742 14774 +32
+ Misses 3879 3855 -24
+ Partials 836 829 -7 ☔ View full report in Codecov by Sentry. |
1 task
tao12345666333
pushed a commit
that referenced
this pull request
Dec 7, 2023
1 task
tao12345666333
pushed a commit
that referenced
this pull request
Dec 7, 2023
1 task
randmonkey
added a commit
that referenced
this pull request
Dec 8, 2023
* Fix: Add --emit-translation-events to toggle creating of events in translation and config applying (#5296) * add --emit-translation-events to toggle creating of events in translation and config applying * update changelog * Update internal/manager/run.go Co-authored-by: Jintao Zhang <[email protected]> * Capitalize logs Co-authored-by: Jakub Warczarek <[email protected]> --------- Co-authored-by: Jintao Zhang <[email protected]> Co-authored-by: Jakub Warczarek <[email protected]> (cherry picked from commit 8b3d551) * fix: change events emit toggle name to --emit-kubernetes-events (#5299) --------- Co-authored-by: Tao Yi <[email protected]> Co-authored-by: Grzegorz Burzyński <[email protected]>
tao12345666333
added a commit
that referenced
this pull request
Dec 8, 2023
* Fix: Add --emit-translation-events to toggle creating of events in translation and config applying (#5296) * add --emit-translation-events to toggle creating of events in translation and config applying * update changelog * Update internal/manager/run.go Co-authored-by: Jintao Zhang <[email protected]> * Capitalize logs Co-authored-by: Jakub Warczarek <[email protected]> --------- Co-authored-by: Jintao Zhang <[email protected]> Co-authored-by: Jakub Warczarek <[email protected]> (cherry picked from commit 8b3d551) * fix: change events emit toggle name to --emit-kubernetes-events (#5299) * docs: re-generate docs/cli-arguments.md Signed-off-by: Jintao Zhang <[email protected]> * Update CHANGELOG Signed-off-by: Jintao Zhang <[email protected]> --------- Signed-off-by: Jintao Zhang <[email protected]> Co-authored-by: Tao Yi <[email protected]> Co-authored-by: Grzegorz Burzyński <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changes the new
--emit-translation-eventsflag name to--emit-kubernetes-eventsas it decides not only about the translation events but all the events we generate (including configuration application success and failure).Which issue this PR fixes:
Part of #5252.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR