Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include CRUD action message from go-database-reconciler in logging error details from Konnect #5453

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Jan 18, 2024

What this PR does / why we need it:

Include op type, entity kind and entity name in CRUD action when logging details of pushing config to Konnect. Based on GDR update Kong/go-database-reconciler#42.

Which issue this PR fixes:

fixes #5274.

Special notes for your reviewer:

Follow up of #5448. Adds operation, entity_kind and entity_name into the logs.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (a75c2b3) 69.6% compared to head (c1a28e5) 69.7%.
Report is 7 commits behind head on main.

Files Patch % Lines
internal/dataplane/kong_client.go 11.1% 15 Missing and 1 partial ⚠️
...ternal/dataplane/translator/translate_httproute.go 81.2% 3 Missing and 3 partials ⚠️
internal/admission/validation/gateway/httproute.go 86.3% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5453     +/-   ##
=======================================
+ Coverage   69.6%   69.7%   +0.1%     
=======================================
  Files        176     176             
  Lines      22661   22752     +91     
=======================================
+ Hits       15778   15875     +97     
  Misses      5940    5940             
+ Partials     943     937      -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randmonkey randmonkey marked this pull request as ready for review January 24, 2024 10:20
@randmonkey randmonkey requested a review from a team as a code owner January 24, 2024 10:20
internal/dataplane/deckerrors/api.go Show resolved Hide resolved
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
@randmonkey randmonkey merged commit 336270f into main Jan 25, 2024
47 checks passed
@randmonkey randmonkey deleted the extract_crud_action_error branch January 25, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include details in the Konnect sync error
2 participants