Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): rename TestUDPRoute to TestUDPRouteEssentials and make similar to TestTCPRouteEssentials #5723

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

programmer04
Copy link
Member

What this PR does / why we need it:

Tests for UDP in KIC are historically overall complex, they use CoreDNS for verification. This PR renames TestUDPRoute toTestUDPRouteEssentials and makes it much simpler (uses the same approach as TestTCPRouteEssentials). It also tests more features (read more in the next section).

Which issue this PR fixes:

Special notes for your reviewer:

Some small opportunistic improvements to TestTCPRouteEssentials have been made too. The last occurrence of CoreDNS in test/integration/udpingress_test.go will be handled in a separate PR.

@programmer04 programmer04 added area/tests area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Mar 19, 2024
@programmer04 programmer04 self-assigned this Mar 19, 2024
@programmer04 programmer04 requested a review from a team as a code owner March 19, 2024 12:29
@programmer04 programmer04 enabled auto-merge (squash) March 19, 2024 12:29
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.8%. Comparing base (8c49b29) to head (c03adf3).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5723   +/-   ##
=====================================
  Coverage   71.7%   71.8%           
=====================================
  Files        175     175           
  Lines      18141   18141           
=====================================
+ Hits       13019   13031   +12     
+ Misses      4170    4165    -5     
+ Partials     952     945    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@programmer04 programmer04 merged commit eaaf069 into main Mar 21, 2024
38 checks passed
@programmer04 programmer04 deleted the TestUDPRouteEssentials branch March 21, 2024 07:27
@programmer04 programmer04 added this to the KIC v3.2.x milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/tests size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants