Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): migrate to isolated and simplify TestUDPIngressEssentials #5743

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

programmer04
Copy link
Member

What this PR does / why we need it:

Tests for UDP in KIC are historically overall complex, they use CoreDNS for verification. This reworks TestUDPIngressEssentials to use an isolated tests framework and makes it much simpler. Instead of CoreDNS it uses kong/go-echo:0.3.0.

Which issue this PR fixes:

Done during work on #5715.
There is also an initiative to get rid of CoreDNS in tests entirely.

Special notes for your reviewer:

What it tests is quite similar to #5724 (previously with Core DNS also such similarity existed) for now I haven't decided to merge them into one test, but I think it's something to consider

@programmer04 programmer04 added area/tests area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Mar 22, 2024
@programmer04 programmer04 self-assigned this Mar 22, 2024
@programmer04 programmer04 requested a review from a team as a code owner March 22, 2024 19:01
@programmer04 programmer04 enabled auto-merge (squash) March 22, 2024 19:01
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.3%. Comparing base (02dca39) to head (385911c).
Report is 2 commits behind head on main.

❗ Current head 385911c differs from pull request most recent head e4e896b. Consider uploading reports for the commit e4e896b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5743     +/-   ##
=======================================
+ Coverage   71.7%   73.3%   +1.5%     
=======================================
  Files        175     175             
  Lines      18141   18141             
=======================================
+ Hits       13023   13306    +283     
+ Misses      4174    3858    -316     
- Partials     944     977     +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/integration/isolated/udpingress_test.go Show resolved Hide resolved
test/integration/isolated/udpingress_test.go Show resolved Hide resolved
test/integration/isolated/udpingress_test.go Outdated Show resolved Hide resolved
test/integration/isolated/udpingress_test.go Show resolved Hide resolved
test/integration/isolated/udpingress_test.go Outdated Show resolved Hide resolved
test/integration/isolated/udpingress_test.go Outdated Show resolved Hide resolved
@programmer04 programmer04 merged commit 81b6a7f into main Mar 25, 2024
36 checks passed
@programmer04 programmer04 deleted the TestUDPIngressEssentials branch March 25, 2024 12:51
@programmer04 programmer04 added this to the KIC v3.2.x milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/tests size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants