-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conformance: add support for GRPCRoute #5776
Conversation
most of these tests have failed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5776 +/- ##
=======================================
- Coverage 73.8% 73.2% -0.7%
=======================================
Files 197 198 +1
Lines 19382 19752 +370
=======================================
+ Hits 14314 14459 +145
- Misses 4085 4301 +216
- Partials 983 992 +9 ☔ View full report in Codecov by Sentry. |
91ff3ed
to
a04d32a
Compare
9d514ca
to
91d2c60
Compare
3257481
to
fa23b77
Compare
fa23b77
to
7bc9b8e
Compare
Blocked by #5918 |
7bc9b8e
to
502847c
Compare
Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
ed43c24
to
1c6a1cb
Compare
For
|
Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM. some minor comments
Signed-off-by: Jintao Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please check whether docs need any updates with the current Kong Gateway this caveat may not be true as discussed on Slack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR mentions that it fixes #5705 but that issue also has an AC to add documentation for GRPC and GRPCS backends.
I'd suggest to remove this note so that we don't close #5705 until the docs are changed to provide manuals for those. If those exists somewhere (I'm not sure) then that should ideally be linked in #5705.
Let me know WDYT.
Co-authored-by: Patryk Małek <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
Co-authored-by: Patryk Małek <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]> Co-authored-by: Patryk Małek <[email protected]>
What this PR does / why we need it:
Which issue this PR fixes:
part of: #5705
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR