fix: do not sanitize plugins' config #6138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
revert-plugins-sanitize
branch
from
4ebf9d7
to
b765bde
Compare
This reverts commit 2d615e3.
czeslavo
force-pushed
the
revert-plugins-sanitize
branch
from
b765bde
to
f38af29
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6138 +/- ##
=======================================
+ Coverage 73.8% 75.5% +1.7%
=======================================
Files 197 197
Lines 19382 19330 -52
=======================================
+ Hits 14314 14611 +297
+ Misses 4085 3726 -359
- Partials 983 993 +10 ☔ View full report in Codecov by Sentry. |
2 tasks
rainest
approved these changes
Jun 6, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.1.x release/3.1.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.1.x
# Create a new branch
git switch --create backport-6138-to-release/3.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 21ad6608c4dcd6367c12189938920812b17cabc0
# Push it to GitHub
git push --set-upstream origin backport-6138-to-release/3.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.1.xThen, create a pull request where the |
pmalek
pushed a commit
that referenced
this pull request
Jun 6, 2024
* fix: do not sanitize plugins' config This reverts commit 2d615e3. * ensure we do not sanitize plugins' config in ut
rainest
pushed a commit
that referenced
this pull request
Jun 6, 2024
* fix: do not sanitize plugins' config This reverts commit 2d615e3. * ensure we do not sanitize plugins' config in ut
1 task
|
Manual backport in #6155 |
rainest
pushed a commit
that referenced
this pull request
Jun 7, 2024
…#6155) * fix: do not sanitize plugins' config This reverts commit 2d615e3. * ensure we do not sanitize plugins' config in ut Co-authored-by: Grzegorz Burzyński <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This reverts commit 2d615e3.
Which issue this PR fixes:
Fixes #5692.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR