Feat(gateway discovery): Add config for gateway readiness check intervals and timeouts #6434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
reviewed
Aug 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6434 +/- ##
======================================
Coverage ? 74.2%
======================================
Files ? 201
Lines ? 20330
Branches ? 0
======================================
Hits ? 15100
Misses ? 4235
Partials ? 995 ☔ View full report in Codecov by Sentry. |
pmalek
previously approved these changes
Aug 21, 2024
czeslavo
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add flags
--gateway-discovery-readiness-check-intervaland--gateway-discovery-readiness-check-timeoutto configure reconciliation interval and timeout of readiness checks.Which issue this PR fixes:
fixes #6425
Special notes for your reviewer:
Naming problem: should we change
ReconciliationIntervaltoReconciliationPeriodto align with other***Periods?PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR