fix: do not index httproute if not enabled #6454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
fix/httproute-kongservice-index
branch
2 times, most recently
from
cd77965
to
096baa9
Compare
czeslavo
force-pushed
the
fix/httproute-kongservice-index
branch
from
096baa9
to
1d06677
Compare
czeslavo
force-pushed
the
fix/httproute-kongservice-index
branch
from
1d06677
to
8ecfa3c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6454 +/- ##
=======================================
+ Coverage 74.1% 75.4% +1.2%
=======================================
Files 202 202
Lines 20491 20492 +1
=======================================
+ Hits 15200 15453 +253
+ Misses 4277 4014 -263
- Partials 1014 1025 +11 ☔ View full report in Codecov by Sentry. |
programmer04
approved these changes
Aug 27, 2024
team-k8s-bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
(cherry picked from commit e2c170e)
czeslavo
added a commit
that referenced
this pull request
Aug 27, 2024
(cherry picked from commit e2c170e) Co-authored-by: Grzegorz Burzyński <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We should not index
HTTPRoutewhenServiceFacadefeature is enabled but no Gateway API CRDs are installed as that will crash the controller.PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR