feat: implement structured logging and remove glog #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbagdi
force-pushed
the
feat/structured-logging
branch
from
39cfcbd
to
171022e
Compare
hbagdi
force-pushed
the
feat/structured-logging
branch
2 times, most recently
from
3e1db20
to
437a697
Compare
hbagdi
force-pushed
the
feat/structured-logging
branch
from
437a697
to
6740b9a
Compare
rainest
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
There is a remaining TODO at https://github.com/Kong/kubernetes-ingress-controller/pull/748/files#diff-5a3256bc175c2a0c1f90487004e63cb3R392 but that may well be intentionally deferred til later.
Even if it's not intended leaving it in shouldn't cause any harm, so going ahead with approval.
Scan through suggests everything is indeed either replaced or was removed old init code that isn't needed in the new system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses logrus to implement structured logging throughout the
repository.
Two new flags have been introduced for managing logging:
--log-leveland
--log-format.Fix #712
Fix #506