deploy: Define port_maps for Kong (OSS + Enterprise) #753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
kong-ingress
is a service exposing low portstcp/80
andtcp/443
. The implementation detail ofdeploy/
is that these get NAT'ed by kube-proxy to high container portstcp/8000
andtcp/8443
of the proxy container. Without knowledge of the externally exposed low ports, Kong puts those high ports inX-Forwarded-Port
request headers which end-users can consider surprising, incorrect and unnecessarily exposing the implementation details of the Kong deployment.This PR sets
KONG_PORT_MAPS
to enable Kong's feature to perform a reverse address translation for the purpose of identifying the actual port a request was received on by the service.This feature is present in Kong as ofedits per #753 (comment)2.1.0-beta.1
, hence also an upgrade of Kong.Which issue this PR fixes
closes #691
Special notes for your reviewer:
Does not touch Kong EnterpriseUpdateskong
from2.0
to2.1.0-beta.1
with an exception ofwait-for-migrations
where it updates from1.3
We probably want to shelve this PR until2.1.0
gets released, and then update this PR to use2.1.0
before merging.