-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo/test manifest divergence #797
Conversation
uses: imranismail/setup-kustomize@v1 | ||
with: | ||
kustomize-version: "3.1.0" | ||
- name: Verify manifest consistency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this check is failing at introduction 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, should have read Special notes for your reviewer first. 🤦
How do we want to handle that?
I recommend a TDD-like approach here:
- introduce a failing test
- fix the cause of failure
- anticipate test success 🎉
For me, this can (or even should) happen in 1 PR. It does not feel right to deliberately introduce a CI failure. I won't insist, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, mostly a question of just where that change goes, which is a minor procedural point and not particularly important.
Given that it's pretty minor and I have the link to an existing test run demonstrating the failure already, going ahead and pushing the manifest updates within this PR.
Co-authored-by: Michał Flendrich <[email protected]>
Latest updates apply @mflendrich 's bash suggestions and comingle a manifest update along with the CI update so that the test now passes. Please refer to the run linked earlier/CI history for a demonstration of the failure case behavior. |
What this PR does / why we need it:
Adds CI task to run the manifest generation script, check if it resulted in changes, and fail if it did. This ensures that single and base manifests do not diverge.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #668Special notes for your reviewer:
https://github.com/Kong/kubernetes-ingress-controller/runs/960118920?check_suite_focus=true failed because it should. The manifests aren't in sync currently. In a local test directory where I have updated them:
How do we want to handle that? Just update them and roll the changes into this PR, or separate PR to update them and then rebase this onto next (or main) after it's merged?