Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Get started about Helm 2 #993

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

ydFu
Copy link
Contributor

@ydFu ydFu commented Dec 19, 2020

What this PR does / why we need it:

Remove about Helm v2 in README.md due to Helm v2 Deprecation.
After November 13, 2020,No further Helm v2 releases.

ref. helm-v2-deprecation-timeline

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mflendrich mflendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the right thing to do; I was wondering about leaving Helm 2 as explicitly deprecated, but it's not a strong opinion.

To make a consistent change. Would you please send a matching PR for https://github.com/Kong/docs.konghq.com/tree/master/app/kubernetes-ingress-controller/1.1.x/deployment/ ?

Setting the "do not merge" label - so that we apply changes both here and to the docs repo simultaneously.

This change looks fine to go to main as opposed to next because Helm 2 is effectively EOL already.

@mflendrich mflendrich added do not merge let the author merge this, don't merge for them. area/docs labels Dec 21, 2020
@ydFu
Copy link
Contributor Author

ydFu commented Dec 22, 2020

@mflendrich
Thanks for your suggestion,it is gains for me.
Send a matching PR to PR in Kong/docs.konghq.com.
I guess they are separate repositorys. Can be handled separately.

@mflendrich
Copy link
Contributor

To be merged when Kong/docs.konghq.com#2524 is merged.

@mflendrich mflendrich removed the do not merge let the author merge this, don't merge for them. label Jan 6, 2021
@mflendrich mflendrich merged commit 1ca0a84 into Kong:main Jan 6, 2021
@ydFu ydFu deleted the updated-readme-get-started branch January 6, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants