Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): add support to EntityBaseTable to use action button outside [KHCP-9618] #913

Merged

Conversation

mptap
Copy link
Contributor

@mptap mptap commented Nov 14, 2023

Summary

https://konghq.atlassian.net/browse/KHCP-9618

Entities Updated:

  • Gateway Services
  • Routes
  • Consumers
  • ConsumerGroups
  • ConsumerCredentials
  • Plugins
  • Upstreams
  • Targets
  • Certificates
  • CACertificates
  • SNIs
  • Vaults
  • Keys
  • KeySets

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@mptap mptap requested review from adamdehaven, jillztom and a team as code owners November 14, 2023 08:31
@mptap mptap self-assigned this Nov 14, 2023
@mptap mptap changed the title feat(*): add support to EntityBaseTable to use action button outside [KHCP-9618] [DNM] feat(*): add support to EntityBaseTable to use action button outside [KHCP-9618] Nov 14, 2023
@mptap mptap force-pushed the feat/khcp-9618-remove-subtitles-descriptions-from-all-pages branch 3 times, most recently from ca89787 to 73e7dbe Compare November 17, 2023 18:20
@jillztom
Copy link
Collaborator

call-to-action-jumping.mov

The call to action buttons are jumping from one place to another when you navigate around. This is probably because of the disabled state of the Teleport and hasData.

:disabled="!useActionOutside || !hasData" this logic needs to be updated. When the component is getting mounted, the hadData is false and the teleport will be disabled causing the jump.

@mptap mptap force-pushed the feat/khcp-9618-remove-subtitles-descriptions-from-all-pages branch from f733ba5 to 2fcba47 Compare November 20, 2023 18:03
@mptap mptap force-pushed the feat/khcp-9618-remove-subtitles-descriptions-from-all-pages branch from 2fcba47 to a13fd9d Compare November 28, 2023 17:55
@mptap mptap changed the title [DNM] feat(*): add support to EntityBaseTable to use action button outside [KHCP-9618] feat(*): add support to EntityBaseTable to use action button outside [KHCP-9618] Nov 28, 2023
@mptap mptap enabled auto-merge (squash) November 28, 2023 23:39
@mptap mptap merged commit bbe5a07 into main Nov 29, 2023
17 checks passed
@mptap mptap deleted the feat/khcp-9618-remove-subtitles-descriptions-from-all-pages branch November 29, 2023 14:53
@@ -13,6 +13,7 @@
preferences-storage-key="kong-ui-entities-ca-certificates-list"
:query="filterQuery"
:table-headers="tableHeaders"
:use-action-outside="useActionOutside"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mptap Should this line be removed? Because EntityBaseTable does not have the use-action-outside prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants