-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): add support to EntityBaseTable to use action button outside [KHCP-9618] #913
feat(*): add support to EntityBaseTable to use action button outside [KHCP-9618] #913
Conversation
packages/core/app-layout/src/components/pageHeader/AppPageHeader.vue
Outdated
Show resolved
Hide resolved
packages/entities/entities-shared/src/components/entity-base-table/EntityBaseTable.vue
Outdated
Show resolved
Hide resolved
packages/entities/entities-gateway-services/src/components/GatewayServiceList.vue
Outdated
Show resolved
Hide resolved
ca89787
to
73e7dbe
Compare
call-to-action-jumping.movThe call to action buttons are jumping from one place to another when you navigate around. This is probably because of the disabled state of the Teleport and hasData.
|
f733ba5
to
2fcba47
Compare
2fcba47
to
a13fd9d
Compare
@@ -13,6 +13,7 @@ | |||
preferences-storage-key="kong-ui-entities-ca-certificates-list" | |||
:query="filterQuery" | |||
:table-headers="tableHeaders" | |||
:use-action-outside="useActionOutside" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mptap Should this line be removed? Because EntityBaseTable
does not have the use-action-outside
prop.
Summary
https://konghq.atlassian.net/browse/KHCP-9618
Entities Updated:
PR Checklist