Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app-layout): body overflow #77

Merged
merged 5 commits into from
Jan 31, 2023
Merged

fix(app-layout): body overflow #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
61cf15c
fix(app-layout): overflow main container
adamdehaven Jan 30, 2023
4df1aa9
fix(app-layout): stylelint
adamdehaven Jan 30, 2023
cd99800
chore: remove placeholder div
adamdehaven Jan 30, 2023
68690cf
Merge branch 'main' into fix/app-layout-overflow
adamdehaven Jan 30, 2023
6286d11
Merge branch 'main' into fix/app-layout-overflow
adamdehaven Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/core/app-layout/src/components/AppLayout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,12 +242,16 @@ onBeforeUnmount(() => {

.kong-ui-app-layout {
background-color: $sidebar-background-gradient-start;
bottom: 0;
display: flex;
flex-direction: column;
font-family: $font-family-base;
height: 100%;
left: 0;
overflow: hidden;
position: relative;
position: fixed;
right: 0;
top: 0;
width: 100%;

:deep(.kong-ui-app-navbar) {
Expand Down Expand Up @@ -277,8 +281,9 @@ onBeforeUnmount(() => {
flex-grow: 1;
height: 100%;
margin-top: v-bind('layoutMainMarginTop');
width: 100%;
// border-top-left-radius: 16px; // TODO: Enable when Neon layout is enabled
overflow: auto;
width: 100%;

@media (min-width: $viewport-md) {
margin-left: $sidebar-width;
Expand Down
6 changes: 3 additions & 3 deletions packages/core/app-layout/src/styles/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ html.kong-ui-app-layout-html {

html.kong-ui-app-layout-html,
body.kong-ui-app-layout-body {
height: 100%; // Reenable these rules to move the scrollbar under the AppNavbar
height: 100vh; // Reenable these rules to move the scrollbar under the AppNavbar
margin: 0;
// height: 100%; // Reenable these rules to move the scrollbar under the AppNavbar
// height: 100vh; // Reenable these rules to move the scrollbar under the AppNavbar
// overflow: hidden; // Reenable these rules to move the scrollbar under the AppNavbar
overflow: hidden; // Reenable these rules to move the scrollbar under the AppNavbar
overscroll-behavior-y: none; // Disable elastic overflow scrolling in Chrome and Safari
padding: 0;
width: 100%;
Expand Down