address issue #484 null headers

Kong · Aug 1, 2023 · c16c3b1 · c16c3b1
1 parent 21605d8
commit c16c3b1
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 5 deletions.
diff --git a/unirest-bdd-tests/src/test/java/BehaviorTests/HeaderTest.java b/unirest-bdd-tests/src/test/java/BehaviorTests/HeaderTest.java
@@ -358,4 +358,13 @@ void replaceHeadersTests() {
                 .assertHeader("foo","replace")
                 .assertHeader("two","bar");
     }
+
+    @Test
+    void nullHeaderValues() {
+        Unirest.get(MockServer.GET)
+                .header("foo", null)
+                .asObject(RequestCapture.class)
+                .getBody()
+                .assertHeader("foo", "");
+    }
 }
diff --git a/unirest/src/test/java/kong/unirest/core/HeadersTest.java b/unirest/src/test/java/kong/unirest/core/HeadersTest.java
@@ -26,14 +26,13 @@
 package kong.unirest.core;
 
 
-
-import kong.unirest.core.Header;
-import kong.unirest.core.Headers;
 import org.junit.jupiter.api.Test;
 
+import java.util.ArrayList;
+import java.util.List;
+
 import static java.util.Arrays.asList;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.*;
 
 class HeadersTest {
 
@@ -106,4 +105,19 @@ void canCreateHeadersFromACollection() {
         assertEquals("application/json", h.getFirst("Accepts"));
         assertEquals("application/xml", h.getFirst("Content-Type"));
     }
+
+    @Test
+    void headersCanBeNull() {
+        var h = new Headers();
+        h.add("foo", (String) null);
+        assertEquals(List.of(""), h.get("foo"));
+    }
+
+    @Test
+    void headersCanBeNull2() {
+        var headers = new Headers();
+        headers.add("header1", "value");
+        headers.add("header2", (String) null);
+        assertEquals(2, headers.size());
+    }
 }