-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load Images (Path) and/or Load Video (Path) Not Working #224
Comments
Oh, I think there is a critical bug for path from the recent update. |
Putting aside the in_place thing that was due to and then fixed in recent commits, I am unable to reproduce the bug with paths not working - here is me trying out both Load Video (Path) and Load Images (Path) with videos/folders that are in arbitrary locations: Only thing that causes an issue is for example having quotes at the start and end of the string - quotes used to be stripped automatically in the past, but I think that may have accidentally been removed as a side effect of the frontend being responsible for more things. @AustinMroz can we bring back stripping of quotes from the beginning and end of paths? In Windows at least, copying the paths of a folder/file will result in quotes surrounding it, so it will make it easier to use. As for the bug, let's congregate all of the other related issues into this one so we don't have 3 separate issue reports. Anyone who is experiencing the bug, please provide your operating system, the string you were trying to input, and a screenshot of your particular (Path) node. Also, try things like not having any widgets turned into inputs for the (Path) nodes to see if that somehow makes the error not happen, and make sure VHS is updated to the most recent version before doing anything else. |
@bkmikaelo7 @itsklimov tagging you guys since you also experienced the issue in the past |
I'm looking into it. As far as I can tell from a quick scan of the revision history, Load Images (Path) has only ever had white space stripping applied, but Load Video (Path) and Load Audio (Path) (still) perform only quote stripping. I support the convenience of quote stripping, and will work on a patch to standardize the stripping of both quotes and whitespace across all nodes. Edit: I can confirm that quote stripping is not currently applied at runtime. |
All path stripping is now performed by a dedicated strip_path function. First all whitespace is stripped, then a single double-quote is stripped from the start and end of the path. Subsequent double quotes or white space inside of the quotes is maintained. Fixed a number of places paths received no stripping - Load Video (Path) execution - Path queries - Advanced Previews - Load Audio See #224
I've pushed a fairly robust rework of path stripping. From what error logs I've seen posted, I don't think it will be enough to resolve all of the reported issues, but it should provide nice QOL. Forgot to bump version though. Will do so soon once I resolve unrelated bugs I encountered in testing this. Edit: After a massive rabbit hole, the version has been bumped and path stripping changes are available to any using the comfy registry. |
I seem to be getting this error every time on one of my two systems, but also with the (Upload) node. Have tried with a few different files, but the node was previously working, and still does on the other system which is still on a previous commit. Here's the details: Path (that probs has the most problematic characters): Commit not working: both Win11 So i tried to checkout the commit that is working and the error persists, even when creating a new workflow (wondered if node version was getting cached if not) but on the messed up system, still messed up. Very confused... Edit: Further details of the error trace: |
Thanks for the detailed response. Between the listed commits, there hasn't been any change to the front end code, so I don't think there is risk of caching. I suspect there was a change or update to opencv-python that broke things for you. There have been weird issues with opencv I've not been able to reproduce before, but I'd start with comparing the opencv version between your systems. |
Same/related issue happened when I try to use the Load Video (Path) in this workflow in AutoDL cloud server. The workflow: https://civitai.com/models/372584/ipivs-morph-img2vid-animatediff-lcm-hyper-sd The video link: https://i.imgur.com/FZojh3v.mp4 Try saving the video to the storage, use local path, different error code:
|
This is the error I'm getting. Turning advanced previews on or off has no impact. PdhAddEnglishCounterW failed. Performance counters may be disabled. File "D:\ComfyUI\ComfyUI\execution.py", line 151, in recursive_execute |
It does seem my issue appears to have resolved by manually uninstalling and installing opencv-python. Thanks! |
@Bastian4523, Your issue appears to be the result of corrupt performance counters (More info here). I'll push a quick commit to handle this more gracefully (by simply disabling the memory limit with a warning). |
Under some circumstances seemingly related to disabled or corrupt performance counters on windows, the psutil.swap_memory() call can fail. This is now handled a bit more gracefully by displaying warning and simply disabling the memory limit. Will likely need revisiting later to not swallow the brief hints on how to fix the issue. See #224
It's simple to recreate. Make a folder on your desktop, drop in some valid images, and then try to load the images in the folder using the Load Images (Path) node. The node will consistently error out on a valid path.
The text was updated successfully, but these errors were encountered: