fix: proper strikethrough in navigation for Fifefox #3156 (#3436)

(cherry picked from commit d416612)
Kotlin · Jan 11, 2024 · 5324006 · 5324006
1 parent 809bfb7
commit 5324006
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/...cts/plugin-base/src/main/kotlin/org/jetbrains/dokka/base/renderers/html/NavigationPage.kt b/...cts/plugin-base/src/main/kotlin/org/jetbrains/dokka/base/renderers/html/NavigationPage.kt
@@ -77,7 +77,7 @@ public class NavigationPage(
 
     private fun FlowContent.nodeText(node: NavigationNode) {
         if (node.styles.contains(TextStyle.Strikethrough)) {
-            strike {
+            strike(classes = "strikethrough") {
                 buildBreakableText(node.name)
             }
         } else {

diff --git a/dokka-subprojects/plugin-base/src/main/resources/dokka/styles/style.css b/dokka-subprojects/plugin-base/src/main/resources/dokka/styles/style.css
@@ -686,6 +686,26 @@ code.paragraph {
     text-decoration: line-through;
 }
 
+/* Workaround for Firefox  https://github.com/Kotlin/dokka/issues/3156 */
+@-moz-document url-prefix() {
+    .strikethrough {
+        position: relative;
+        text-decoration: none;
+    }
+
+    /* complex selectors here are required to handle multiline cases */
+    .strikethrough::after, .strikethrough span:after  {
+        content: '';
+        position: absolute;
+        top: 7px;
+        left: 0;
+        right: 0;
+        height: 1px;
+        background-color: currentColor;
+        z-index: 1;
+    }
+}
+
 .symbol:empty {
     padding: 0;
 }