On this page #1504
Merged
On this page #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcinAman
force-pushed
the
on-this-page
branch
from
27f9716
to
1fc987b
Compare
MarcinAman
force-pushed
the
1054-anchors-hint
branch
from
fd5db51
to
6cc6334
Compare
sellophane
reviewed
Sep 28, 2020
plugins/base/src/main/kotlin/allModulePage/MultimodulePageCreator.kt
Outdated
Show resolved
Hide resolved
| @@ -103,6 +106,7 @@ open class HtmlRenderer( | |||
| } | |||
| node.hasStyle(TextStyle.Paragraph) -> p(additionalClasses) { childrenCallback() } | |||
| node.hasStyle(TextStyle.Block) -> div(additionalClasses) { childrenCallback() } | |||
| node.isAnchorable -> buildAnchor(node.anchor, node.anchorLabel!!, node.sourceSetsFilters) { childrenCallback() } | |||
There was a problem hiding this comment.
Must we have a !! here?
There was a problem hiding this comment.
yes, because without it this doesn't make sense.
Also this wont produce NPE since isAnchorable checks if anchorLabel != null
Kordyjan
reviewed
Sep 28, 2020
MarcinAman
force-pushed
the
on-this-page
branch
2 times, most recently
from
d1d2b32
to
c5d54af
Compare
|
I dont know if you have realized but this PR depends on: #1307, so this one also needs a review ;D |
MarcinAman
force-pushed
the
1054-anchors-hint
branch
from
6cc6334
to
b7dfbf3
Compare
MarcinAman
force-pushed
the
on-this-page
branch
from
c5d54af
to
8819dc9
Compare
kamildoleglo
force-pushed
the
1054-anchors-hint
branch
from
03f7099
to
2c9e112
Compare
MarcinAman
force-pushed
the
1054-anchors-hint
branch
2 times, most recently
from
9ca5ae7
to
cee5ab7
Compare
|
/rebase |
MarcinAman
force-pushed
the
on-this-page
branch
2 times, most recently
from
1c2006b
to
7bceb0a
Compare
MarcinAman
force-pushed
the
on-this-page
branch
from
7bceb0a
to
fe86ded
Compare
This was referenced Mar 16, 2021
[Dependency]: Bump dokka-gradle-plugin from 0.10.1 to 1.4.30
PatilShreyas/EasyUpiPayment-Android#100
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component is available on pages with tabs and anchors as for other pages it doesn't make sense.
It is made to be on hover, just to quickly navigate to desired section.
What do you think about it?