-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update mobile view and some bugs #2836
Conversation
447630f
to
5474214
Compare
b57f2af
to
959f046
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
plugins/base/src/main/resources/dokka/scripts/platform-content-handler.js
Outdated
Show resolved
Hide resolved
Created a separate issue for this: #2964 Also, if it's not too much to ask, can you disable showing this "copy anchor" popup if JS is disabled? It's not going to work if it's pressed. Hover over any function/property name from the left column |
And a question on the source set buttons in the header. I don't know if it's a bug in my browser or if it's intended, but on wide monitors the buttons look huge and have a different shape (rounded corners). It's especially strange to see when you're looking at the page with packages that have the same source set indicators, but in a different shape However, if I shrink the page horizontally, the buttons change their shape and are smaller, which is nice. Can we stick to one style and size only (the one below)? Also, the buttons themselves are quite confusing, it's not clear what their purpose is and how they help the reader, ideally we want to redesign it completely (see #2779). For this reason, maybe it makes sense to make them smaller to not draw so much attention? What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not easy work, thank you!
Nothing critical, just a few comments.
plugins/base/src/main/resources/dokka/styles/jetbrains-mono.css
Outdated
Show resolved
Hide resolved
a9f77d2
to
ef7429f
Compare
Created a separate issue for my no-JS indicator proposal: #2964 |
β¦round, menu icon is black
β¦xel artifacts and centred content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome ππ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome ππ
Link to live demo π
Fix bugs β :
sidebar
is white in dark themeUpdated header view πΌοΈ:
Issues photos π:
see photos