Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Gradle tasks #2909

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Remove unused Gradle tasks #2909

merged 1 commit into from
Mar 9, 2023

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Mar 8, 2023 •
edited
Loading

This PR removes some defined, but unused, Gradle tasks

These custom sourceJar tasks are not used. A sourcesJar is auto-created using withSourcesJar()

dokka/buildSrc/src/main/kotlin/org/jetbrains/conventions/base-java.gradle.kts

Lines 20 to 22 in 6b46d95

java {
withSourcesJar()
}

@IgnatBeresnev IgnatBeresnev self-requested a review March 9, 2023 11:40
IgnatBeresnev
IgnatBeresnev approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@IgnatBeresnev IgnatBeresnev merged commit 6fcd66a into Kotlin:master Mar 9, 2023
@aSemy aSemy deleted the fix/remove_unused_tasks branch March 9, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnatBeresnev IgnatBeresnev IgnatBeresnev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aSemy @IgnatBeresnev