Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Developer Guides #3088

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Update Developer Guides #3088

merged 3 commits into from
Aug 4, 2023

Conversation

IgnatBeresnev
Copy link
Member

Checked the Developer guides about any incorrect information in regards to the analysis refactoring - everything looks good.

Made some changes as I read through, mostly based on what I learned from working with our technical writers and writing Dokka's user-facing documentation.

Also renamed the module, otherwise having mkdocs all by itself is not very descriptive, especially when there is already a docs module next to it (which should ideally be docs-user or something)

docs-developer/README.md Show resolved Hide resolved
* `Input` - generalization of sources, by default Kotlin / Java sources, but could be virtually anything
* `Documentables` - unified data model that represents _any_ parsed sources as a tree, independent of the source
language. Examples of a `Documentable`: class, function, package, property, etc
* `Pages` - universal model that represents output pages (e.g a function/property page) and the content it's composed of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would clarify that the universal model is independent of the target format output.

Copy link
Member Author

@IgnatBeresnev IgnatBeresnev Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth trying to keep the architecture overview page short and concise, and give clarifications on the dedicated pages.

Here, the word "universal" and the sentence "Not to be confused with .html pages" are implying that it's independent, and it's explained in more detail on the page/content model page.

I've added hyperlinks to the names so that it's easier to find details

* `Pages` - universal model that represents output pages (e.g a function/property page) and the content it's composed of
(lists, text, code blocks) that the users needs to see. Not to be confused with `.html` pages. Goes hand in hand
with so-called "Content model".
* `Output` - specific output format like HTML / Markdown / Javadoc and so on. This is a mapping of the pages/content
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that Javadoc is worth mentioning since it has no Content Model at all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this bullet point is about the output abstraction in the context of the architecture overview, not about the implementation details of the Javadoc output format? I don't think it should matter as long as the reader understands the general concept of how it might work

@IgnatBeresnev IgnatBeresnev merged commit f7bd2ce into master Aug 4, 2023
9 checks passed
@IgnatBeresnev IgnatBeresnev deleted the update-developer-docs branch August 4, 2023 16:59
IgnatBeresnev added a commit that referenced this pull request Aug 8, 2023
(cherry picked from commit f7bd2ce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants