Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compileDependencyFiles for getting compilation dependencies #3147

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

antohaby
Copy link
Contributor

No description provided.

Add KotlinNativeDistributionAccessor

It uses internal KGP API but since Kotlin 2.0
Kotlin Native Distribution dependencies will be included to compileDependencyFiles.
@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Aug 30, 2023

@antohaby looks like some integration tests failed due to unresolved classes, could you please have a look?

Android0GradleIntegrationTest:

java.lang.AssertionError: Unexpected `ERROR CLASS` in /mnt/agent/temp/buildTmp/junit14604582596950190122/project/build/dokka/html/it-android-0/it.android/-android-specific-class/create-view.html

You should be able to run these simple integration tests from IDEA. However, if you need to run kotlinx.coroutines / kotlinx.serialization / biojava integration tests, you'll need to initialize git submodules first

@vmishenev
Copy link
Member

vmishenev commented Aug 30, 2023

looks like some integration tests failed due to unresolved classes, could you please have a look?

This failing is only for Kotlin 1.9.0

It can happen due to

if (this.target.isAndroidTarget()) { // Workaround for https://youtrack.jetbrains.com/issue/KT-33893
that is not used in new (current) resolving for Kotlin 1.9.0.

@IgnatBeresnev IgnatBeresnev merged commit 9809ae7 into master Oct 9, 2023
12 checks passed
@IgnatBeresnev IgnatBeresnev deleted the alakotka/stable-compilation-classpath branch October 9, 2023 11:28
vmishenev added a commit to vmishenev/dokka that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants