Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to com.gradleup.shadow #3739

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Aug 11, 2024

@adam-enko adam-enko added the infrastructure Everything related to builds tools, CI configurations and project tooling label Aug 12, 2024
@adam-enko
Copy link
Member

Good idea, thanks!

For clarity, the reason for this change is that the Shadow plugin was transferred to a different maintainer, as explained in https://github.com/GradleUp/shadow/releases/tag/8.3.0

BREAKING CHANGE: the GitHub has been transferred from johnrengelman/shadow to GradleUp/shadow, you can view more details in GradleUp/shadow#908.

@Goooler
Copy link
Contributor Author

Goooler commented Aug 12, 2024

Yeah, this release also contains the adoption of the new file permission API from Gradle 8.3.

Copy link
Collaborator

@whyoleg whyoleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Just to be sure, rechecked locally - final built artefact is absolutely the same

@whyoleg whyoleg merged commit 570d958 into Kotlin:master Aug 12, 2024
7 checks passed
@Goooler Goooler deleted the migrate-shadow branch August 12, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Everything related to builds tools, CI configurations and project tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants