-
-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support footnotes #1509
Merged
Support footnotes #1509
Commits on Nov 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 88e589b - Browse repository at this point
Copy the full SHA 88e589bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75e3435 - Browse repository at this point
Copy the full SHA 75e3435View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20fdc45 - Browse repository at this point
Copy the full SHA 20fdc45View commit details -
Configuration menu - View commit details
-
Copy full SHA for da1cd5e - Browse repository at this point
Copy the full SHA da1cd5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b36671b - Browse repository at this point
Copy the full SHA b36671bView commit details
Commits on Nov 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1c3fd97 - Browse repository at this point
Copy the full SHA 1c3fd97View commit details
Commits on Nov 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for fe5fa64 - Browse repository at this point
Copy the full SHA fe5fa64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f61ce9 - Browse repository at this point
Copy the full SHA 9f61ce9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2da0a6c - Browse repository at this point
Copy the full SHA 2da0a6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c90886c - Browse repository at this point
Copy the full SHA c90886cView commit details
Commits on Nov 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b633bef - Browse repository at this point
Copy the full SHA b633befView commit details
Commits on Nov 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a3b7f7f - Browse repository at this point
Copy the full SHA a3b7f7fView commit details -
Replace max_position_y by bottom_space
As the bottom of the page is now dynamic (because it changes with footnotes), passing the max_position_y is difficult: it would require the value to be passed to layout functions, and returned (possibly updated) by these functions. The new solution is to store the page bottom in the context, and to update it when a footnote is included. The new max position y is calculated when needed, using the updated position of the page bottom. To handle extra bottom spaces (bottom padding/border/margin of a parent box for example), a bottom_space parameter is given when needed. This value can be set to -inf when we don’t want to take care of the page bottom (that’s equivalent to max_position_y=inf).
Configuration menu - View commit details
-
Copy full SHA for 6a9dac4 - Browse repository at this point
Copy the full SHA 6a9dac4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36b7452 - Browse repository at this point
Copy the full SHA 36b7452View commit details
Commits on Nov 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f5e520e - Browse repository at this point
Copy the full SHA f5e520eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f60b81 - Browse repository at this point
Copy the full SHA 8f60b81View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5d3475 - Browse repository at this point
Copy the full SHA b5d3475View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6da2c9 - Browse repository at this point
Copy the full SHA e6da2c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d42b0fa - Browse repository at this point
Copy the full SHA d42b0faView commit details
Commits on Nov 30, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c5f03c2 - Browse repository at this point
Copy the full SHA c5f03c2View commit details
Commits on Dec 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for dfc3d0a - Browse repository at this point
Copy the full SHA dfc3d0aView commit details
Commits on Dec 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6f190a2 - Browse repository at this point
Copy the full SHA 6f190a2View commit details -
Make footnote call’s style inherit from the footnote’s parent
There’s nothing in the specification about that, but here’s what we do now: - The style of a footnote inherits from its parent’s style, it doesn’t inherit from the footnote area’s style. That’s how cascade works for real elements, and there’s no real reason or way to avoid this. - The style of a footnote marker inherits from the footnote style. The marker is just like a ::before block regarding to its style, even if it is actually put before the footnote element in the footnote body. - The style of a footnote call inherits from the footnote parent’s style. It doesn’t inherit from the footnote’s style, that’s actually applied to the footnote and inherited by its marker. This way, we keep the "normal" cascade for "normal" elements, and have everything else being quite obvious. The 1st point is annoying in real-life use cases, because we’d really like to see the footnote’s style inherit from the footnote area’s style. But we really don’t want to break the cascade. Do we? No, we don’t. The 3rd point is probably the most disturbing one, mainly because .footnote::footnote-call doesn’t match the call: to match a footnote call in a paragraph, for example, we have to use p::footnote-call instead.
Configuration menu - View commit details
-
Copy full SHA for 7aa0860 - Browse repository at this point
Copy the full SHA 7aa0860View commit details -
Configuration menu - View commit details
-
Copy full SHA for 232d9ef - Browse repository at this point
Copy the full SHA 232d9efView commit details -
Handling footnote-display requires the footnote area children to be recreated each time one footnote is added: as footnotes can be blocks or inlines, we have to create anonymous boxes each time, and thus to do the whole footnote area layout.
Configuration menu - View commit details
-
Copy full SHA for 313a09d - Browse repository at this point
Copy the full SHA 313a09dView commit details
Commits on Dec 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a702292 - Browse repository at this point
Copy the full SHA a702292View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed0916d - Browse repository at this point
Copy the full SHA ed0916dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e6b21c - Browse repository at this point
Copy the full SHA 5e6b21cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c8c291 - Browse repository at this point
Copy the full SHA 7c8c291View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7126f1b - Browse repository at this point
Copy the full SHA 7126f1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f54da35 - Browse repository at this point
Copy the full SHA f54da35View commit details
Commits on Dec 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8cc6b25 - Browse repository at this point
Copy the full SHA 8cc6b25View commit details -
Configuration menu - View commit details
-
Copy full SHA for d457486 - Browse repository at this point
Copy the full SHA d457486View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1800bb5 - Browse repository at this point
Copy the full SHA 1800bb5View commit details
Commits on Dec 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3f596ce - Browse repository at this point
Copy the full SHA 3f596ceView commit details
Commits on Dec 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 21484fa - Browse repository at this point
Copy the full SHA 21484faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87e4765 - Browse repository at this point
Copy the full SHA 87e4765View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.