Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named pages #495

Merged
merged 19 commits into from
Aug 9, 2017
Merged

Named pages #495

merged 19 commits into from
Aug 9, 2017

Conversation

liZe
Copy link
Member

@liZe liZe commented Aug 4, 2017

See #57.

Random things:

  • simple cases are tested, but it's hard to find reliable and clear tests (there's nothing in the W3C suite),
  • implementing fragmentation is a must-have if we want to handle complicated cases (and fix many issues including Rewrite the line breaking algorithm #301),
  • page styles are not lazily generated,
  • some added code is slow, naive and stupid,
  • speciality of pages is wrong and could be easily fixed,
  • Prince has been a good tool to check that I've understood what's in the spec 😉.

liZe added 14 commits July 17, 2017 22:48
@liZe
Use a custom object instead of constants for page pseudo-classes
c004dc4 
This is a first step to lazily get the page styles and support named pages.
@liZe
Set the page styles lazily
30e4098
@liZe
Fix docstring
f8088c3
@liZe
Handle the page property
9270697
@liZe
Fix computed value of 'page' attribute
cb45253
@liZe
Remove the all_names attribute of matching_page_types
fb40d56
@liZe
Merge branch 'master' into namedpages
84dd9b8
@liZe
Update the documentation about paged media
6b1c5ab
@liZe
Merge branch 'master' into namedpages
645116f
@liZe
Return the next page value in block_level_page_break
86be0e9
@liZe
Always return the next page name in block_level_page_break
5cc1ffe 
Use the 'break' returned value to force the page break
@liZe
Include the page name in the next_page variable
63f687f
@liZe
Give the page name when creating PageTypes
508b365
@liZe
Basic support of named pages
515d85f 
Fix #57.
@liZe liZe added the feature New feature that should be supported label Aug 4, 2017
@liZe liZe added this to the v0.40 milestone Aug 4, 2017
@liZe liZe merged commit 55fab4b into master Aug 9, 2017
@liZe liZe deleted the namedpages branch August 9, 2017 10:02
@liZe liZe mentioned this pull request Oct 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New feature that should be supported
Projects
None yet
Milestone
v0.40
Development

Successfully merging this pull request may close these issues.
1 participant
@liZe