Use pdfrw instead of editing PDF files directly #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans code and fixes Python 2 support.
Added support to work with bleed like padding (bleed-top/right/bottom…
We have to compare various PDF objects to compare PDF files as pdfrw doesn't produce the same PDF files from the same input. That's caused by Python's unordered dicts. Comparing pdf bytes thus works with Python 3.6+ where dicts are ordered.
Even if it's not officially documented, dicts are ordered in Python 3.6. We relied on this to assert that PDF generation was reproducible, it works on some versions of Python 3.6 but not on Travis for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes what was a beautiful hack, but it's probably better done in an external library.
It also adds support of bleed boxes.