feat(core): add support for receiving unsupported tx types #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
ArtificialPB
force-pushed
the
feat/eip4844
branch
from
53d14a9
to
7286694
Compare
ArtificialPB
force-pushed
the
feat/unsupported-txs
branch
from
0164491
to
89e7758
Compare
ArtificialPB
force-pushed
the
feat/eip4844
branch
from
7286694
to
22fb026
Compare
ArtificialPB
force-pushed
the
feat/unsupported-txs
branch
from
89e7758
to
9a828b7
Compare
ArtificialPB
force-pushed
the
feat/unsupported-txs
branch
from
24c274b
to
55db1be
Compare
ArtificialPB
force-pushed
the
feat/eip4844
branch
from
906d538
to
123a184
Compare
ArtificialPB
force-pushed
the
feat/unsupported-txs
branch
from
55db1be
to
38710ed
Compare
This change allows the library to receive any tx type, regardless whether it's officially supported. Supported transactions can be constructed, signed, and sent and are subclasses of TransactionUnsigned. TxType has been converted to a sealed class to preserve exhaustive compiler checks in "when" statements. Unsupported transaction types are wrapped into TxType.Unsupported. This PR also changes TransactionReceipt.type field to have the same type as transactions.
ArtificialPB
force-pushed
the
feat/unsupported-txs
branch
from
38710ed
to
686d34e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows the library to receive any tx type, regardless whether it's officially
supported. Supported transactions can be constructed, signed, and sent and are subclasses
of TransactionUnsigned.
It's now possible to receive optimism's system transactions: https://github.com/ethereum-optimism/optimism/blob/develop/specs/deposits.md#the-deposited-transaction-type
Tx example: https://optimistic.etherscan.io/tx/0x92a7dc8085945e32810b5fb4fb002f024b487861145457bd1cdb60a1fac0d59c
Solution
TxType has been converted to a sealed class to preserve exhaustive compiler checks in "when"
statements. Unsupported transaction types are wrapped into TxType.Unsupported.
This PR also changes TransactionReceipt.type field to have the same type as transactions.