fix!: make encoding/decoding RLP lists non-ambiguous by returning empty List instead of null #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty List instead of null Addtionally: - fixed chainId field decoding on RPCTransaction if the json field was NULL - make Transaction#accessList not null and default to empty List if not set. Previously, missing access list could be set either as null or as empty list, leading to ambiguous and broken comparison checks
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
…d the one we were using
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make encoding/decoding RLP lists non-ambiguous by returning empty List instead of null.
Addtionally:
Solution