UINavigationBar isHidden bugfix #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the offset of the view is not correctly calculated. I added the - (BOOL)isNavigationBarInNavigationControllerHidden:(UINavigationController *)navController method to check the navigation controller isNavigationBarHidden property and the navigation controllers navigationBar isHidden property. In the example project there is a debug value for navigationBar.hidden and it must be removed in the main release.
…roller *)navController is now a static method call. removed the debug value in the example project calculating the view height in TSMessageView is now correct
|
@dennisreimann this should be implemented in the develop branch as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the navigation bar is hidden via the hidden value of the UINavigationBar the calculation of the position is done wrong.
I added a new static method to fix this bug. I think this should be added to the develop branch as well.