-
Notifications
You must be signed in to change notification settings - Fork 28
Fix deprecated reflection type to string #19
Fix deprecated reflection type to string #19
Conversation
Also fixes deprecation warnings on PHP >= 7.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! It seems like a great way to keep backwards compatibility with PHP 7.0 (even if it's EOL).
There were some smaller code style issues that I have highlighted.
You were able to test your changes before submitting, right? Sadly I don't have any environment set up right now.
Hi. I've tested it locally in one of my projects, but I'm only able to test with PHP 7.4. |
Sadly I'm not familiar with the recent tools and practices in PHP so I couldn't say :/ |
Just a status check. Are you happy with the changes I made? |
Sorry for the delay. It has been released in https://github.com/KristofMorva/laravel-ide-macros/releases/tag/1.5.0 Thank you for your contribution! :) |
Hello @mortenscheel, it seems to break #21. Could you please make a change which does not use |
Hi @KristofMorva |
\ReflectionType::__toString()
was deprecated in PHP 7.1.This PR fixes the issue by using
\ReflectionNamedType
when the PHP version is >= 7.1.I've also included a couple of commits with coding standard fixes that are not related to this issue.