Skip to content
This repository has been archived by the owner on Sep 8, 2023. It is now read-only.

Replace PresetCommand with Command #5

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

CupOfTea696
Copy link
Contributor

The PresetCommand itself doesn't use the Macroable trait, the base Command class does, so that should be the class the ide helpers are added for.

@KristofMorva
Copy link
Owner

Thank you, do you happen to know if it's a longstanding bug in this package, or has it changed in one of the versions? I have updated this list a long time ago, it might be worth to check which Macroable classes have changed / been removed / were added.

@CupOfTea696
Copy link
Contributor Author

@KristofMorva Sorry, I have no idea

@KristofMorva
Copy link
Owner

KristofMorva commented May 20, 2019

All right, I'll check it out :)

@KristofMorva
Copy link
Owner

Looks valid, custom Artisan Console Commands extend Illuminate\Console\Command, which without this PR seems to be unsupported.

Thanks!

@KristofMorva KristofMorva merged commit 4757c9c into KristofMorva:master Sep 17, 2019
@CupOfTea696 CupOfTea696 deleted the patch-1 branch September 17, 2019 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants