Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL Search History not working with Julia 1.10.4 #362

Closed
PGS62 opened this issue Jul 17, 2024 · 3 comments · Fixed by #363
Closed

REPL Search History not working with Julia 1.10.4 #362

PGS62 opened this issue Jul 17, 2024 · 3 comments · Fixed by #363

Comments

@PGS62
Copy link

PGS62 commented Jul 17, 2024

With Julia 1.10.4 and OhMyREPL 0.5.27 when I hit Ctrl+R, I see recent commands but hitting enter does not recall the currently selected line (and the julia> prompt disappears). Things work correctly with Julia 1.9.4 and OhMyREPL 0.5.27.

This is on Windows, but I've also seen the same issue on MacOS with Julia 1.7 and OhMyREPL 0.5.27 and on Ubuntu under WSL2 with Julia 1.10.4 and OhMyREPL 0.5.27, so I don't think it's a Windows-only issue.

I didn't realise how much I liked search history until I had to do without it!

@disberd
Copy link

disberd commented Jul 17, 2024

I have also noticed this on my windows machine after updating to 0.5.27.
I just tried reverting to v0.5.24 and the issue disappears also in v1.10.4, so it only seems broken on OhMyREPL > 0.5.24 AND julia 1.10.4.

On versions between 0.5.25 and 0.5.26 at least on windows it seems to have explicit errors when trying to load the history, while in 0.5.27 just silently fails as explained in the post above from @PGS62

@roflmaostc
Copy link

I observe the same on Linux and 1.10.4

@sandyspiers
Copy link
Contributor

I've noticed the same thing.

It looks like it might have been introduced in #347.
Dropping this commit locally fixes the issue for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants