Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix disappearing fzf matches #363

Merged
merged 2 commits into from
Aug 5, 2024
Merged

fix disappearing fzf matches #363

merged 2 commits into from
Aug 5, 2024

Conversation

sandyspiers
Copy link
Contributor

Fixes #362.

Working locally on Julia 1.10.4, 1.9.4, 1.8.5 on my Linux machine.

@Moelf
Copy link
Contributor

Moelf commented Jul 19, 2024

I no longer remember what that function does anymore....

also I wonder if we need withenv("FZF_DEFAULT_OPTS" => nothing) do again

@sandyspiers
Copy link
Contributor Author

Sure, probably safest to add it back.

In future, we could check for a JLFZF_DEFAULT_OPTS environment variable if desired.
This way we keep it separate from FZF_DEFAULT_OPTS.

@disberd
Copy link

disberd commented Jul 24, 2024 •
edited
Loading

Thanks @sandyspiers,

I confirm that this fixes the issue also for me on Windows and julia 1.11-rc1 and 1.10.4

@KristofferC KristofferC merged commit 70bacf2 into KristofferC:master Aug 5, 2024
9 of 10 checks passed
@sandyspiers sandyspiers deleted the fix-disappearing-fzf branch August 5, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REPL Search History not working with Julia 1.10.4
4 participants
@sandyspiers @Moelf @disberd @KristofferC