Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing transpose expressions #202

Merged
merged 2 commits into from
Aug 17, 2020
Merged

fixing transpose expressions #202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6ab136
fixing transpose expressions
daviehh Jun 14, 2020
92b828a
no regex
daviehh Jun 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/BracketInserter.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,14 @@ function peek(b::IOBuffer)
return c
end

# when we should not close the bracket
function no_closing_bracket(left_peek, v)
# left_peek == v: we already have an open quote immediately before (triple quote)
# tr_expr is for transposing calls: issue #200
tr_expr = isletter(left_peek) || isnumeric(left_peek) || left_peek == '_' || left_peek == ']'
left_peek == v || (v == '\'' && tr_expr)
end

const AUTOMATIC_BRACKET_MATCH = Ref(!Sys.iswindows())
enable_autocomplete_brackets(v::Bool) = AUTOMATIC_BRACKET_MATCH[] = v

Expand Down Expand Up @@ -105,8 +113,7 @@ function insert_into_keymap!(D::Dict)
# Next char is the quote symbol so just move right
if !eof(b) && peek(b) == v
edit_move_right(b)
# we already have an open quote immediately before (triple quote)
elseif position(b) > 0 && leftpeek(b) == v
elseif position(b) > 0 && no_closing_bracket(leftpeek(b), v)
edit_insert(b, v)
else
edit_insert(b, v)
Expand Down