Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Fzf for windows experience #221

Merged
merged 1 commit into from
Sep 6, 2020
Merged

Conversation

Moelf
Copy link
Contributor

@Moelf Moelf commented Sep 3, 2020

Reason probably is that if you do full screen windows terminal would clear the buffer.

@musm
Copy link
Contributor

musm commented Sep 4, 2020

I don't have a problem with this, but I think the bug is actually in the fzf library, because the same behavior is exhibited when using that library directly. It seems like they don't correctly restore it back

EDIT: actually, sorry that's incorrect, it does work, I was testing an older commit.

@Moelf
Copy link
Contributor Author

Moelf commented Sep 4, 2020

So, I saw this: https://github.com/genotrance/ff ; if you look closely, it looks like the buffer is not restored; and in here: https://github.com/kelleyma49/PSFzf ; the buffer is kept but it's also NOT full-screen. My speculation is that this is some windows terminal buffer issue (no allow two separate buffers for example), so when you limit the height, fzf will preserve the buffer history for you.

On a separate note, the oh-my-zsh + fzf also does NOT do full-screen so I actually like this behavior better. Justification? so you can see what you were trying to type before by looking at previous lines.

@KristofferC
Copy link
Owner

I like this more too

@KristofferC KristofferC merged commit feedcfb into KristofferC:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants